Skip to content

Add create_event function to create event string#71

Merged
dgarciabriseno merged 9 commits into
Helioviewer-Project:mainfrom
akash5100:event_strings_workaround
Aug 29, 2022
Merged

Add create_event function to create event string#71
dgarciabriseno merged 9 commits into
Helioviewer-Project:mainfrom
akash5100:event_strings_workaround

Conversation

@akash5100

@akash5100 akash5100 commented Aug 24, 2022

Copy link
Copy Markdown
Collaborator

@akash5100 akash5100 self-assigned this Aug 24, 2022
Comment thread hvpy/tests/test_utils.py Outdated
@codecov-commenter

codecov-commenter commented Aug 25, 2022

Copy link
Copy Markdown

Codecov Report

Merging #71 (84e098f) into main (5ca472d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   99.51%   99.53%   +0.01%     
==========================================
  Files          24       24              
  Lines         622      640      +18     
==========================================
+ Hits          619      637      +18     
  Misses          3        3              
Impacted Files Coverage Δ
hvpy/utils.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Comment thread hvpy/utils.py Outdated
@nabobalis
nabobalis force-pushed the event_strings_workaround branch from 167a9e8 to 9b2bbf5 Compare August 28, 2022 16:24
Comment thread hvpy/utils.py

@dgarciabriseno dgarciabriseno left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works great.

@dgarciabriseno
dgarciabriseno merged commit a56ebfe into Helioviewer-Project:main Aug 29, 2022
@akash5100
akash5100 deleted the event_strings_workaround branch August 29, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need a way to construct Event strings

4 participants